Skip to content

fix: move MintableERC721 interface#3946

Merged
mergify[bot] merged 1 commit intodevelopfrom
sc/ctb-move-mintable-interface
Nov 10, 2022
Merged

fix: move MintableERC721 interface#3946
mergify[bot] merged 1 commit intodevelopfrom
sc/ctb-move-mintable-interface

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented Nov 9, 2022

Description
Moves the interface for the OptimismMintableERC721 into the SupportedInterfaces file where the rest of the interfaces are.

@smartcontracts
fix: move MintableERC721 interface
6fbd06e 
Moves the interface for the OptimismMintableERC721 into the
SupportedInterfaces file where the rest of the interfaces are.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 9, 2022

⚠️ No Changeset found

Latest commit: 6fbd06e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Nov 9, 2022
@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 9, 2022

Having this not need to regenerate more files is nice

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Nov 9, 2022
@mergify
Merge of #3946
01cf413
@mergify mergify bot mentioned this pull request Nov 9, 2022
Closed
95 tasks
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify bot added a commit that referenced this pull request Nov 9, 2022
@mergify
Merge of #3946
aed67f7
@mergify mergify bot mentioned this pull request Nov 9, 2022
Closed
95 tasks
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2022

Hey @smartcontracts, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@mergify mergify bot removed the on-merge-train label Nov 9, 2022
@smartcontracts
Copy link
Copy Markdown
Contributor Author

smartcontracts commented Nov 10, 2022

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Nov 10, 2022
@mergify
Merge of #3946
795801f
@mergify mergify bot mentioned this pull request Nov 10, 2022
Closed
91 tasks
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify bot added a commit that referenced this pull request Nov 10, 2022
@mergify
Merge of #3946
707e932
mergify bot added a commit that referenced this pull request Nov 10, 2022
@mergify
Merge of #3946
7a58399
@mergify mergify bot merged commit c4bb465 into develop Nov 10, 2022
@mergify mergify bot deleted the sc/ctb-move-mintable-interface branch November 10, 2022 04:55
@mergify mergify bot removed the on-merge-train label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@maurelian maurelian maurelian approved these changes

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smartcontracts @tynes @maurelian